Bug 105925 - [MinGW-w64] Centralize workaround for pow() implementation
Summary: [MinGW-w64] Centralize workaround for pow() implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Hausmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-02 08:14 PST by Simon Hausmann
Modified: 2013-01-03 01:56 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.51 KB, patch)
2013-01-02 08:16 PST, Simon Hausmann 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2013-01-02 08:14:17 PST 
[MinGW-w64] Centralize workaround for pow() implementation
Comment 1 Simon Hausmann 2013-01-02 08:16:20 PST 
Created attachment 181031 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-02 08:18:30 PST 
Attachment 181031 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/WTF/wtf/MathExtras.h:230:  wtf_pow is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jonathan Liu 2013-01-02 13:37:14 PST 
Missing blank line before "return pow(x, y);".
Comment 4 Simon Hausmann 2013-01-03 01:56:37 PST 
Committed r138705: <http://trac.webkit.org/changeset/138705>