Bug 105714 - Web Inspector: [Console] Add "Replay XHR" context menu item for corresponding messages.
Summary: Web Inspector: [Console] Add "Replay XHR" context menu item for corresponding...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eugene Klyuchnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-24 02:06 PST by Eugene Klyuchnikov
Modified: 2012-12-25 01:15 PST (History)
10 users (show)

See Also:

Attachments
Patch (3.64 KB, patch)
2012-12-24 02:14 PST, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Patch (3.52 KB, patch)
2012-12-24 03:20 PST, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Klyuchnikov 2012-12-24 02:06:44 PST 
Original issue: https://code.google.com/p/chromium/issues/detail?id=166518
Comment 1 Eugene Klyuchnikov 2012-12-24 02:14:44 PST 
Created attachment 180658 [details]
Patch
Comment 2 Pavel Feldman 2012-12-24 02:33:02 PST 
Comment on attachment 180658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180658&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:465
> +                NetworkAgent.replayXHR(requestId);

Bind it instead.
Comment 3 Eugene Klyuchnikov 2012-12-24 03:17:15 PST 
Comment on attachment 180658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180658&action=review

>> Source/WebCore/inspector/front-end/ConsoleView.js:465
>> +                NetworkAgent.replayXHR(requestId);
> 
> Bind it instead.

ok
Comment 4 Eugene Klyuchnikov 2012-12-24 03:20:06 PST 
Created attachment 180660 [details]
Patch
Comment 5 WebKit Review Bot 2012-12-24 04:07:35 PST 
Comment on attachment 180660 [details]
Patch

Attachment 180660 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15497413

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Comment 6 WebKit Review Bot 2012-12-25 01:15:04 PST 
Comment on attachment 180660 [details]
Patch

Clearing flags on attachment: 180660

Committed r138458: <http://trac.webkit.org/changeset/138458>
Comment 7 WebKit Review Bot 2012-12-25 01:15:08 PST 
All reviewed patches have been landed.  Closing bug.