Bug 105685 – Cleanup perftest* tests and add a test for computing statistics

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

This is a preparation for the bug 97510. We need a test for calculate_statistics, and we need to refactor tests.

[Ryosuke Niwa]

Created attachment 180617 [details]
Patch

[WebKit Review Bot]

Attachment 180617 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1
Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:210:  expected 1 blank line, found 0  [pep8/E301] [5]
Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:498:  [MainTest.test_upload_json.MockFileUploader.__init__] Method should have "self" as first argument  [pylint/E0213] [5]
Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:503:  [MainTest.test_upload_json.MockFileUploader.upload_single_text_file] Method should have "self" as first argument  [pylint/E0213] [5]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Seidel (no email)]

Comment on attachment 180617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180617&action=review

OK.

> Tools/Scripts/webkitpy/performance_tests/perftest.py:215
> +    @staticmethod
> +    def compute_statistics(values):

static methods are rarely worth it in python. :(  They're just hard to mock.

[WebKit Review Bot]

Comment on attachment 180617 [details]
Patch

Clearing flags on attachment: 180617

Committed r138774: <http://trac.webkit.org/changeset/138774>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/12955988>