Bug 105424 - [Qt] Add new TestExpectations for qt-5.0-wk2-mac.
Summary: [Qt] Add new TestExpectations for qt-5.0-wk2-mac.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-19 05:41 PST by Zeno Albisser
Modified: 2012-12-21 01:08 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.92 KB, patch)
2012-12-19 05:46 PST, Zeno Albisser 		no flags Details | Formatted Diff | Diff
Patch (6.86 KB, patch)
2012-12-19 07:12 PST, Zeno Albisser 		no flags Details | Formatted Diff | Diff
Patch (6.88 KB, patch)
2012-12-20 02:39 PST, Zeno Albisser 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2012-12-19 05:41:42 PST 
[Qt] Add new TestExpectations for qt-5.0-wk2-mac.
Comment 1 Zeno Albisser 2012-12-19 05:46:41 PST 
Created attachment 180145 [details]
Patch
Comment 2 Zeno Albisser 2012-12-19 07:12:25 PST 
Created attachment 180161 [details]
Patch
Comment 3 Dirk Pranke 2012-12-19 12:00:34 PST 
Comment on attachment 180161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180161&action=review

Mostly looks fine, one suggestion ...

> Tools/Scripts/webkitpy/layout_tests/port/qt.py:132
> +                    search_paths.append('qt-5.0-wk2-mac')

Can we call this 'qt-mac-5.0-wk2'? That would seem to be more consistent with the other port names.
Comment 4 Zeno Albisser 2012-12-20 02:24:18 PST 
(In reply to comment #3)
> Can we call this 'qt-mac-5.0-wk2'? That would seem to be more consistent with the other port names.
I don't have any strong preferences here. But qt-mac-5.0 sounds a bit uncommon in Qt environments.
So I would instead suggest qt-5.0-mac-wk2. Do you think that would be okay?
Comment 5 Zeno Albisser 2012-12-20 02:39:11 PST 
Created attachment 180307 [details]
Patch
Comment 6 Dirk Pranke 2012-12-20 09:30:59 PST 
Comment on attachment 180307 [details]
Patch

Yeah, I can live with that :)
Comment 7 Zeno Albisser 2012-12-21 01:08:21 PST 
Comment on attachment 180307 [details]
Patch

Clearing flags on attachment: 180307

Committed r138353: <http://trac.webkit.org/changeset/138353>
Comment 8 Zeno Albisser 2012-12-21 01:08:26 PST 
All reviewed patches have been landed.  Closing bug.