RESOLVED FIXED 105424
[Qt] Add new TestExpectations for qt-5.0-wk2-mac. 
https://bugs.webkit.org/show_bug.cgi?id=105424
Summary [Qt] Add new TestExpectations for qt-5.0-wk2-mac.
Zeno Albisser
Reported 2012-12-19 05:41:42 PST
[Qt] Add new TestExpectations for qt-5.0-wk2-mac.
Attachments
Patch (5.92 KB, patch)
2012-12-19 05:46 PST, Zeno Albisser 		no flags
DetailsFormatted DiffDiff
Patch (6.86 KB, patch)
2012-12-19 07:12 PST, Zeno Albisser 		no flags
DetailsFormatted DiffDiff
Patch (6.88 KB, patch)
2012-12-20 02:39 PST, Zeno Albisser 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zeno Albisser
Comment 1 2012-12-19 05:46:41 PST
Created attachment 180145 [details] Patch
Zeno Albisser
Comment 2 2012-12-19 07:12:25 PST
Created attachment 180161 [details] Patch
Dirk Pranke
Comment 3 2012-12-19 12:00:34 PST
Comment on attachment 180161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180161&action=review Mostly looks fine, one suggestion ... > Tools/Scripts/webkitpy/layout_tests/port/qt.py:132 > + search_paths.append('qt-5.0-wk2-mac') Can we call this 'qt-mac-5.0-wk2'? That would seem to be more consistent with the other port names.
Zeno Albisser
Comment 4 2012-12-20 02:24:18 PST
(In reply to comment #3) > Can we call this 'qt-mac-5.0-wk2'? That would seem to be more consistent with the other port names. I don't have any strong preferences here. But qt-mac-5.0 sounds a bit uncommon in Qt environments. So I would instead suggest qt-5.0-mac-wk2. Do you think that would be okay?
Zeno Albisser
Comment 5 2012-12-20 02:39:11 PST
Created attachment 180307 [details] Patch
Dirk Pranke
Comment 6 2012-12-20 09:30:59 PST
Comment on attachment 180307 [details] Patch Yeah, I can live with that :)
Zeno Albisser
Comment 7 2012-12-21 01:08:21 PST
Comment on attachment 180307 [details] Patch Clearing flags on attachment: 180307 Committed r138353: <http://trac.webkit.org/changeset/138353>
Zeno Albisser
Comment 8 2012-12-21 01:08:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.