Bug 105392 - [EFL] regression(r138071) Add mission functions for build fix
Summary: [EFL] regression(r138071) Add mission functions for build fix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: KyungTae Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-18 23:05 PST by KyungTae Kim
Modified: 2012-12-18 23:34 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.75 KB, patch)
2012-12-18 23:08 PST, KyungTae Kim 		no flags Details | Formatted Diff | Diff
Patch (1.75 KB, patch)
2012-12-18 23:16 PST, KyungTae Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description KyungTae Kim 2012-12-18 23:05:36 PST 
r138071 add new functions in WebCore/platform/LocalizedStrings.cpp, but EFL port doesn't use it.
So, add that functions to WebCore/platform/efl/LocalizedStringsEfl.cpp
Comment 1 KyungTae Kim 2012-12-18 23:08:36 PST 
Created attachment 180095 [details]
Patch
Comment 2 Ryosuke Niwa 2012-12-18 23:15:43 PST 
Comment on attachment 180095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180095&action=review

> Source/WebCore/ChangeLog:9
> +        So, add that functions to LocalizedStringsEfl.cpp 

add “those” functions.
Comment 3 KyungTae Kim 2012-12-18 23:16:59 PST 
Created attachment 180100 [details]
Patch
Comment 4 WebKit Review Bot 2012-12-18 23:34:06 PST 
Comment on attachment 180100 [details]
Patch

Clearing flags on attachment: 180100

Committed r138120: <http://trac.webkit.org/changeset/138120>
Comment 5 WebKit Review Bot 2012-12-18 23:34:09 PST 
All reviewed patches have been landed.  Closing bug.