WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
104448
[GTK] Bump the jhbuild libsoup version to fix an authentication issue
https://bugs.webkit.org/show_bug.cgi?id=104448
Summary
[GTK] Bump the jhbuild libsoup version to fix an authentication issue
Martin Robinson
Reported
2012-12-08 11:25:26 PST
http://git.gnome.org/browse/libsoup/commit/?id=f9816e366e53004618abcee1741885b69e9466a8
fixed a bug causing authentication tests to fail. We should bump the libsoup version to include this fix so that tests pass.
Attachments
Patch
(2.92 KB, patch)
2012-12-09 04:23 PST
,
Martin Robinson
gustavo
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Martin Robinson
Comment 1
2012-12-09 04:23:35 PST
Created
attachment 178409
[details]
Patch
Gustavo Noronha (kov)
Comment 2
2012-12-10 07:22:54 PST
Comment on
attachment 178409
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=178409&action=review
> Tools/gtk/jhbuild.modules:169 > - <branch module="libsoup" version="2.39.2" > + <branch module="libsoup" version="2.39.2-1"
I'm bumping libsoup to 2.40 in my multipart patch which I'm landing now, so I guess you can remove this and leave just the glib bump? It doesn't seem to be required, but if you think it's a good idea I'm for it.
Martin Robinson
Comment 3
2012-12-11 04:10:21 PST
(In reply to
comment #2
)
> (From update of
attachment 178409
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=178409&action=review
> > > Tools/gtk/jhbuild.modules:169 > > - <branch module="libsoup" version="2.39.2" > > + <branch module="libsoup" version="2.39.2-1" > > I'm bumping libsoup to 2.40 in my multipart patch which I'm landing now, so I guess you can remove this and leave just the glib bump? It doesn't seem to be required, but if you think it's a good idea I'm for it.
Yep. We require changes from the tip-of-tree of libsoup. The version number I used here was incredibly misleading. Sorry!
Martin Robinson
Comment 4
2012-12-11 04:11:10 PST
Committed
r137286
: <
http://trac.webkit.org/changeset/137286
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug