WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
104357
Web Inspector: enable inspector tests on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=104357
Summary
Web Inspector: enable inspector tests on chromium-mac
Ilya Tikhonovsky
Reported
2012-12-07 02:31:45 PST
After chromium
r171707
patch we can enable inspector tests on chromium-mac
Attachments
Patch
(19.94 KB, patch)
2012-12-07 04:24 PST
,
Ilya Tikhonovsky
no flags
Details
Formatted Diff
Diff
Patch
(19.43 KB, patch)
2012-12-07 04:40 PST
,
Ilya Tikhonovsky
pfeldman
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1
2012-12-07 04:24:43 PST
Created
attachment 178196
[details]
Patch
Pavel Feldman
Comment 2
2012-12-07 04:26:48 PST
Comment on
attachment 178196
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=178196&action=review
> LayoutTests/platform/chromium/TestExpectations:1023 > +
webkit.org/b/91435
[ Linux Win Mac ] http/tests/inspector/extensions-ignore-cache.html [ Pass Timeout ]
Here and below: should you replace "Linux Win Mac" with nothing?
Ilya Tikhonovsky
Comment 3
2012-12-07 04:40:22 PST
Created
attachment 178198
[details]
Patch
WebKit Review Bot
Comment 4
2012-12-07 04:43:32 PST
Attachment 178198
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] LayoutTests/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ilya Tikhonovsky
Comment 5
2012-12-07 04:48:37 PST
Committed
r136945
: <
http://trac.webkit.org/changeset/136945
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug