Bug 104357 - Web Inspector: enable inspector tests on chromium-mac
Summary: Web Inspector: enable inspector tests on chromium-mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-07 02:31 PST by Ilya Tikhonovsky
Modified: 2012-12-07 04:48 PST (History)
9 users (show)

See Also:


Attachments
Patch (19.94 KB, patch)
2012-12-07 04:24 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (19.43 KB, patch)
2012-12-07 04:40 PST, Ilya Tikhonovsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-12-07 02:31:45 PST
After chromium r171707 patch we can enable inspector tests on chromium-mac
Comment 1 Ilya Tikhonovsky 2012-12-07 04:24:43 PST
Created attachment 178196 [details]
Patch
Comment 2 Pavel Feldman 2012-12-07 04:26:48 PST
Comment on attachment 178196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178196&action=review

> LayoutTests/platform/chromium/TestExpectations:1023
> +webkit.org/b/91435 [ Linux Win Mac ] http/tests/inspector/extensions-ignore-cache.html [ Pass Timeout ]

Here and below: should you replace "Linux Win Mac" with nothing?
Comment 3 Ilya Tikhonovsky 2012-12-07 04:40:22 PST
Created attachment 178198 [details]
Patch
Comment 4 WebKit Review Bot 2012-12-07 04:43:32 PST
Attachment 178198 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Ilya Tikhonovsky 2012-12-07 04:48:37 PST
Committed r136945: <http://trac.webkit.org/changeset/136945>