Bug 103990 - Layout Test css3/filters/effect-reference-hw.html, effect-reference-ordering-hw.html is failing
Summary: Layout Test css3/filters/effect-reference-hw.html, effect-reference-ordering-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-04 03:15 PST by Takashi Sakamoto
Modified: 2012-12-04 15:34 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Takashi Sakamoto 2012-12-04 03:15:57 PST 
The following layout test is crash on Linux, Win and Mac:

css3/filters/effect-reference-hw.html
css3/filters/effect-reference-ordering-hw.html

Probable cause:
This is caused by the patch, http://src.chromium.org/viewvc/chrome?view=rev&revision=170889 in chromium side:
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/compositor_bindings/web_layer_impl.cc?r1=170889&r2=170888&pathrev=170889

When running the above tests, the following code will be executed:
397             SkiaImageFilterBuilder builder;
398             SkAutoTUnref<SkImageFilter> imageFilter(builder.build(filters));
399             m_layer->layer()->setFilter(imageFilter);
(in Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp)

I'm not sure whether it is correct or not, but imageFilter is set to be 0.
So "filter->ref();" in web_layer_impl.cc causes crash. (i.e. NULL->ref(); )

Currently I will mark these tests as crash.
Comment 1 Stephen White 2012-12-04 06:40:11 PST 
Dana, can you take a look?
Comment 2 Stephen White 2012-12-04 06:41:58 PST 
Should probably be SkSafeRef() on the Chrome side.
Comment 3 Dana Jansens 2012-12-04 09:40:16 PST 
Oh.. doh. Yes.
Comment 4 Dana Jansens 2012-12-04 15:07:14 PST 
Looks like they are not crashing anymore, hooray! I'll remove the expectation.
Comment 5 Dana Jansens 2012-12-04 15:34:09 PST 
I can't see any expectations for these tests, though they are showing up in the dashboard pointing to this bug.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Ffilters%2Feffect-reference-hw.html%2Ccss3%2Ffilters%2Feffect-reference-ordering-hw.html

So I'll assume someone removed the Crash expectation already.