Bug 103814 - Correct the spelling of cmakeargs
Summary: Correct the spelling of cmakeargs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-01 07:11 PST by Laszlo Gombos
Modified: 2012-12-02 04:44 PST (History)
5 users (show)

See Also:

Attachments
proposed patch (1.50 KB, patch)
2012-12-01 07:16 PST, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2012-12-01 07:11:09 PST 
build-webkit --help reports "cmakearg" but the script expects "cmakeargs" (plural). 

The EFL WebKit Wiki (http://trac.webkit.org/wiki/EFLWebKit) also references "cmakearg"  (which does not work at the moment on WebKit trunk).

We should address these inconsistencies.
Comment 1 Laszlo Gombos 2012-12-01 07:16:28 PST 
Created attachment 177105 [details]
proposed patch

I will fix the wiki after the patch lands (and there is an agreement that we fix the documentation and not the script behavior).

It seems that the original patch from https://bugs.webkit.org/show_bug.cgi?id=72156 was also intent to have cmakeargs.
Comment 2 WebKit Review Bot 2012-12-02 04:44:17 PST 
Comment on attachment 177105 [details]
proposed patch

Clearing flags on attachment: 177105

Committed r136340: <http://trac.webkit.org/changeset/136340>
Comment 3 WebKit Review Bot 2012-12-02 04:44:21 PST 
All reviewed patches have been landed.  Closing bug.