RESOLVED FIXED 103814
Correct the spelling of cmakeargs 
https://bugs.webkit.org/show_bug.cgi?id=103814
Summary Correct the spelling of cmakeargs
Laszlo Gombos
Reported 2012-12-01 07:11:09 PST
build-webkit --help reports "cmakearg" but the script expects "cmakeargs" (plural). The EFL WebKit Wiki (http://trac.webkit.org/wiki/EFLWebKit) also references "cmakearg" (which does not work at the moment on WebKit trunk). We should address these inconsistencies.
Attachments
proposed patch (1.50 KB, patch)
2012-12-01 07:16 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2012-12-01 07:16:28 PST
Created attachment 177105 [details] proposed patch I will fix the wiki after the patch lands (and there is an agreement that we fix the documentation and not the script behavior). It seems that the original patch from https://bugs.webkit.org/show_bug.cgi?id=72156 was also intent to have cmakeargs.
WebKit Review Bot
Comment 2 2012-12-02 04:44:17 PST
Comment on attachment 177105 [details] proposed patch Clearing flags on attachment: 177105 Committed r136340: <http://trac.webkit.org/changeset/136340>
WebKit Review Bot
Comment 3 2012-12-02 04:44:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.