Bug 103809 - Turn pixel tests in dom/xhtml/level3/core into reftests
Summary: Turn pixel tests in dom/xhtml/level3/core into reftests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-30 23:30 PST by Zan Dobersek
Modified: 2012-12-06 00:33 PST (History)
5 users (show)

See Also:

Attachments
Patch (197.94 KB, patch)
2012-11-30 23:46 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (197.92 KB, patch)
2012-12-01 00:15 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-11-30 23:30:56 PST 
Turn pixel tests in dom/xhtml/level3/core into reftests
Comment 1 Zan Dobersek 2012-11-30 23:46:12 PST 
Created attachment 177093 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-30 23:55:58 PST 
Attachment 177093 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/dom/..." exit_code: 1
LayoutTests/ChangeLog:27:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zan Dobersek 2012-12-01 00:15:53 PST 
Created attachment 177094 [details]
Patch
Comment 4 Zan Dobersek 2012-12-01 23:20:37 PST 
(In reply to comment #3)
> Created an attachment (id=177094) [details]
> Patch

Tested on Chromium Linux and GTK.
Comment 5 Dirk Pranke 2012-12-05 17:38:33 PST 
Comment on attachment 177094 [details]
Patch

nice.
Comment 6 Zan Dobersek 2012-12-06 00:33:09 PST 
Comment on attachment 177094 [details]
Patch

Clearing flags on attachment: 177094

Committed r136814: <http://trac.webkit.org/changeset/136814>
Comment 7 Zan Dobersek 2012-12-06 00:33:15 PST 
All reviewed patches have been landed.  Closing bug.