Bug 103659 - [BlackBerry] Do not adjust scroll position on viewport resizes that are not orientation change related
Summary: [BlackBerry] Do not adjust scroll position on viewport resizes that are not o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrew Lo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-29 12:23 PST by Andrew Lo
Modified: 2012-11-29 13:26 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.07 KB, patch)
2012-11-29 12:27 PST, Andrew Lo
no flags Details | Formatted Diff | Diff
Patch (2.07 KB, patch)
2012-11-29 12:35 PST, Andrew Lo
no flags Details | Formatted Diff | Diff
Patch (2.05 KB, patch)
2012-11-29 12:46 PST, Andrew Lo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Lo 2012-11-29 12:23:24 PST
For viewport resizes that are not due to orientation changes, do not adjust scroll position.
Comment 1 Andrew Lo 2012-11-29 12:27:47 PST
Created attachment 176786 [details]
Patch
Comment 2 Rob Buis 2012-11-29 12:29:39 PST
Comment on attachment 176786 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2012-11-29 12:30:30 PST
Attachment 176786 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1
Source/WebKit/blackberry/Api/WebPage.cpp:3641:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Andrew Lo 2012-11-29 12:35:32 PST
Created attachment 176790 [details]
Patch
Comment 5 Rob Buis 2012-11-29 12:39:03 PST
Comment on attachment 176790 [details]
Patch

Retry.
Comment 6 WebKit Review Bot 2012-11-29 12:40:06 PST
Attachment 176790 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1
Source/WebKit/blackberry/Api/WebPage.cpp:3641:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Andrew Lo 2012-11-29 12:46:18 PST
Created attachment 176794 [details]
Patch
Comment 8 Rob Buis 2012-11-29 12:47:29 PST
Comment on attachment 176794 [details]
Patch

These rules are silly IMHO.
Comment 9 WebKit Review Bot 2012-11-29 13:26:15 PST
Comment on attachment 176794 [details]
Patch

Clearing flags on attachment: 176794

Committed r136157: <http://trac.webkit.org/changeset/136157>
Comment 10 WebKit Review Bot 2012-11-29 13:26:19 PST
All reviewed patches have been landed.  Closing bug.