Bug 103615 - Log to console when forms and popups are blocked by 'sandbox'.
Summary: Log to console when forms and popups are blocked by 'sandbox'.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks: 101964
  Show dependency tree / graph
 
Reported: 2012-11-29 01:16 PST by Mike West
Modified: 2012-12-07 05:36 PST (History)
5 users (show)

See Also:

Attachments
Patch (9.74 KB, patch)
2012-11-29 01:19 PST, Mike West 		no flags Details | Formatted Diff | Diff
Tests. (11.31 KB, patch)
2012-11-29 13:17 PST, Mike West 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2012-11-29 01:16:19 PST 
Continuing to skim through the sandbox flags we're currently not logging. This touches the two call sites in FrameLoader.cpp.
Comment 1 Mike West 2012-11-29 01:19:56 PST 
Created attachment 176673 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-29 11:58:15 PST 
Comment on attachment 176673 [details]
Patch

Attachment 176673 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15054059

New failing tests:
http/tests/security/no-popup-from-sandbox.html
http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html
Comment 3 Mike West 2012-11-29 13:17:35 PST 
Created attachment 176799 [details]
Tests.
Comment 4 Mike West 2012-12-04 01:41:36 PST 
Friendly ping. :)
Comment 5 WebKit Review Bot 2012-12-04 10:35:23 PST 
Comment on attachment 176799 [details]
Tests.

Clearing flags on attachment: 176799

Committed r136527: <http://trac.webkit.org/changeset/136527>
Comment 6 WebKit Review Bot 2012-12-04 10:35:26 PST 
All reviewed patches have been landed.  Closing bug.