Bug 103583 - Update String Stats for recent dataLog changes and add summary
Summary: Update String Stats for recent dataLog changes and add summary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-28 17:35 PST by Michael Saboff
Modified: 2012-11-28 18:22 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.19 KB, patch)
2012-11-28 17:45 PST, Michael Saboff 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-11-28 17:35:08 PST 
Change set r135469 from https://bugs.webkit.org/show_bug.cgi?id=103001 renamed the dataLog functions by adding an 'F' (for file) to the name.  The String Stats code in StringImpl.cpp did not get updated with that change.

I also added a summary of savings in bytes and percent of memory to the total statistics to a local copy of StringImpl.cpp
Comment 1 Michael Saboff 2012-11-28 17:45:03 PST 
Created attachment 176616 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-28 18:22:45 PST 
Comment on attachment 176616 [details]
Patch

Clearing flags on attachment: 176616

Committed r136082: <http://trac.webkit.org/changeset/136082>
Comment 3 WebKit Review Bot 2012-11-28 18:22:48 PST 
All reviewed patches have been landed.  Closing bug.