Bug 103448 - Improve WebSocketChannel connection failure console messages.
Summary: Improve WebSocketChannel connection failure console messages.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-27 12:38 PST by Mike West
Modified: 2012-11-27 23:59 PST (History)
3 users (show)

See Also:

Attachments
Patch (42.13 KB, patch)
2012-11-27 12:41 PST, Mike West 		no flags Details | Formatted Diff | Diff
Patch for landing (42.78 KB, patch)
2012-11-27 23:40 PST, Mike West 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2012-11-27 12:38:29 PST 
Improve WebSocketChannel connection failure console messages.
Comment 1 Mike West 2012-11-27 12:41:42 PST 
Created attachment 176327 [details]
Patch
Comment 2 Mike West 2012-11-27 12:53:01 PST 
See https://bugs.webkit.org/show_bug.cgi?id=100650#c33 for context. :)
Comment 3 WebKit Review Bot 2012-11-27 18:47:09 PST 
Comment on attachment 176327 [details]
Patch

Attachment 176327 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15029178

New failing tests:
http/tests/inspector/web-socket-frame-error.html
Comment 4 Build Bot 2012-11-27 19:50:22 PST 
Comment on attachment 176327 [details]
Patch

Attachment 176327 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15016259

New failing tests:
http/tests/inspector/web-socket-frame-error.html
Comment 5 Mike West 2012-11-27 23:40:41 PST 
Created attachment 176412 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-11-27 23:59:25 PST 
Comment on attachment 176412 [details]
Patch for landing

Clearing flags on attachment: 176412

Committed r135981: <http://trac.webkit.org/changeset/135981>
Comment 7 WebKit Review Bot 2012-11-27 23:59:28 PST 
All reviewed patches have been landed.  Closing bug.