RESOLVED FIXED 103180
Remove use of deprecated logging from most of webkitpy.tool 
https://bugs.webkit.org/show_bug.cgi?id=103180
Summary Remove use of deprecated logging from most of webkitpy.tool
Zan Dobersek
Reported 2012-11-24 10:07:16 PST
Remove use of deprecated logging from most of webkitpy.tool
Attachments
Patch (143.93 KB, patch)
2012-11-24 10:26 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-11-24 10:26:23 PST
Created attachment 175860 [details] Patch
Zan Dobersek
Comment 2 2012-11-24 10:35:49 PST
Comment on attachment 175860 [details] Patch I haven't really discussed this with anyone yet, but since logging through stderr is labeled as deprecated I think there's a tendency to have it removed. The patch replaces such logging with the use of Logger instances. Replacements for the error method calls also include calls to sys.exit(1) to keep the deprecated behavior. This should probably be improved.
Dirk Pranke
Comment 3 2012-11-26 11:14:53 PST
Comment on attachment 175860 [details] Patch Nice cleanup!
WebKit Review Bot
Comment 4 2012-11-26 11:32:41 PST
Comment on attachment 175860 [details] Patch Clearing flags on attachment: 175860 Committed r135744: <http://trac.webkit.org/changeset/135744>
WebKit Review Bot
Comment 5 2012-11-26 11:32:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.