Bug 103180 - Remove use of deprecated logging from most of webkitpy.tool
Summary: Remove use of deprecated logging from most of webkitpy.tool
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-24 10:07 PST by Zan Dobersek
Modified: 2012-11-26 11:32 PST (History)
3 users (show)

See Also:


Attachments
Patch (143.93 KB, patch)
2012-11-24 10:26 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-11-24 10:07:16 PST
Remove use of deprecated logging from most of webkitpy.tool
Comment 1 Zan Dobersek 2012-11-24 10:26:23 PST
Created attachment 175860 [details]
Patch
Comment 2 Zan Dobersek 2012-11-24 10:35:49 PST
Comment on attachment 175860 [details]
Patch

I haven't really discussed this with anyone yet, but since logging through stderr is labeled as deprecated I think there's a tendency to have it removed.

The patch replaces such logging with the use of Logger instances. Replacements for the error method calls also include calls to sys.exit(1) to keep the deprecated behavior. This should probably be improved.
Comment 3 Dirk Pranke 2012-11-26 11:14:53 PST
Comment on attachment 175860 [details]
Patch

Nice cleanup!
Comment 4 WebKit Review Bot 2012-11-26 11:32:41 PST
Comment on attachment 175860 [details]
Patch

Clearing flags on attachment: 175860

Committed r135744: <http://trac.webkit.org/changeset/135744>
Comment 5 WebKit Review Bot 2012-11-26 11:32:45 PST
All reviewed patches have been landed.  Closing bug.