Bug 103160 - [BlackBerry] Define platform limitations in platform layer
Summary: [BlackBerry] Define platform limitations in platform layer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-23 14:27 PST by Nima Ghanavatian
Modified: 2012-11-23 17:31 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.33 KB, patch)
2012-11-23 14:31 PST, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Patch (3.26 KB, patch)
2012-11-23 15:35 PST, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2012-11-23 14:27:25 PST 
Moving some static const's out of webkit repo; general cleanup in InputHandler.
Comment 1 Nima Ghanavatian 2012-11-23 14:31:24 PST 
Created attachment 175836 [details]
Patch
Comment 2 Rob Buis 2012-11-23 15:13:24 PST 
Comment on attachment 175836 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2012-11-23 15:15:46 PST 
Comment on attachment 175836 [details]
Patch

Rejecting attachment 175836 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
angeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/blackberry/Api/WebPageClient.h
Hunk #1 FAILED at 152.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPageClient.h.rej
patching file Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
Hunk #3 succeeded at 616 (offset -4 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14970604
Comment 4 Nima Ghanavatian 2012-11-23 15:35:32 PST 
Created attachment 175840 [details]
Patch
Comment 5 Nima Ghanavatian 2012-11-23 15:36:11 PST 
whoops, had another patch underneath this that caused a merge conflict.
fixed now.
Comment 6 Rob Buis 2012-11-23 17:07:52 PST 
Comment on attachment 175840 [details]
Patch

Ok. retrying.
Comment 7 WebKit Review Bot 2012-11-23 17:31:05 PST 
Comment on attachment 175840 [details]
Patch

Clearing flags on attachment: 175840

Committed r135639: <http://trac.webkit.org/changeset/135639>
Comment 8 WebKit Review Bot 2012-11-23 17:31:08 PST 
All reviewed patches have been landed.  Closing bug.