WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
103002
[V8] WebCoreStringResourceBase should be located in V8StringResource.h
https://bugs.webkit.org/show_bug.cgi?id=103002
Summary
[V8] WebCoreStringResourceBase should be located in V8StringResource.h
Kentaro Hara
Reported
2012-11-21 18:24:38 PST
Currently WebCoreStringResourceBase is mis-located in V8ValueCache.h. It should be in V8StringResource.h.
Attachments
Patch
(13.06 KB, patch)
2012-11-21 18:26 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2012-11-21 18:26:22 PST
Created
attachment 175559
[details]
Patch
WebKit Review Bot
Comment 2
2012-11-21 23:35:51 PST
Comment on
attachment 175559
[details]
Patch Clearing flags on attachment: 175559 Committed
r135482
: <
http://trac.webkit.org/changeset/135482
>
WebKit Review Bot
Comment 3
2012-11-21 23:35:54 PST
All reviewed patches have been landed. Closing bug.
Kentaro Hara
Comment 4
2012-11-22 00:13:53 PST
Reverted
r135482
for reason: It broke Chrome/Linux Debug build Committed
r135488
: <
http://trac.webkit.org/changeset/135488
>
Kentaro Hara
Comment 5
2012-11-22 01:29:22 PST
Committed
r135494
: <
http://trac.webkit.org/changeset/135494
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug