Bug 103002 - [V8] WebCoreStringResourceBase should be located in V8StringResource.h
Summary: [V8] WebCoreStringResourceBase should be located in V8StringResource.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-21 18:24 PST by Kentaro Hara
Modified: 2012-11-22 01:29 PST (History)
3 users (show)

See Also:

Attachments
Patch (13.06 KB, patch)
2012-11-21 18:26 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-11-21 18:24:38 PST 
Currently WebCoreStringResourceBase is mis-located in V8ValueCache.h. It should be in V8StringResource.h.
Comment 1 Kentaro Hara 2012-11-21 18:26:22 PST 
Created attachment 175559 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-21 23:35:51 PST 
Comment on attachment 175559 [details]
Patch

Clearing flags on attachment: 175559

Committed r135482: <http://trac.webkit.org/changeset/135482>
Comment 3 WebKit Review Bot 2012-11-21 23:35:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Kentaro Hara 2012-11-22 00:13:53 PST 
Reverted r135482 for reason:

It broke Chrome/Linux Debug build

Committed r135488: <http://trac.webkit.org/changeset/135488>
Comment 5 Kentaro Hara 2012-11-22 01:29:22 PST 
Committed r135494: <http://trac.webkit.org/changeset/135494>