Bug 102978 – [BlackBerry] Prevent screen from dimming on device when inspector front-end is connected

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Konrad Piascik]

[BlackBerry] Prevent screen from dimming on device when inspector front-end is connected

[Konrad Piascik]

Created attachment 175519 [details]
Patch

[Rob Buis]

Comment on attachment 175519 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175519&action=review

LGTM.

> Source/WebKit/blackberry/Api/WebPage.cpp:5223
> +    d->setPreventsScreenDimming(true);

Seems like setPreventScreenDimming is the better name, but you are just using this API.

> Source/WebKit/blackberry/Api/WebPage.cpp:5230
> +        d->m_page->settings()->setDeveloperExtrasEnabled(false);

Would be nice to make this call implicit.

[Konrad Piascik]

(In reply to comment #2)
> (From update of attachment 175519 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175519&action=review
> 
> LGTM.
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:5223
> > +    d->setPreventsScreenDimming(true);
> 
> Seems like setPreventScreenDimming is the better name, but you are just using this API.
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:5230
> > +        d->m_page->settings()->setDeveloperExtrasEnabled(false);
> 
> Would be nice to make this call implicit.

I'll work on a follow-up patch to fix the API.

[WebKit Review Bot]

Comment on attachment 175519 [details]
Patch

Clearing flags on attachment: 175519

Committed r135441: <http://trac.webkit.org/changeset/135441>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.