Bug 102978 - [BlackBerry] Prevent screen from dimming on device when inspector front-end is connected
Summary: [BlackBerry] Prevent screen from dimming on device when inspector front-end i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konrad Piascik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-21 14:03 PST by Konrad Piascik
Modified: 2012-11-21 15:02 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.96 KB, patch)
2012-11-21 14:06 PST, Konrad Piascik 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konrad Piascik 2012-11-21 14:03:30 PST 
[BlackBerry] Prevent screen from dimming on device when inspector front-end is connected
Comment 1 Konrad Piascik 2012-11-21 14:06:25 PST 
Created attachment 175519 [details]
Patch
Comment 2 Rob Buis 2012-11-21 14:10:22 PST 
Comment on attachment 175519 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175519&action=review

LGTM.

> Source/WebKit/blackberry/Api/WebPage.cpp:5223
> +    d->setPreventsScreenDimming(true);

Seems like setPreventScreenDimming is the better name, but you are just using this API.

> Source/WebKit/blackberry/Api/WebPage.cpp:5230
> +        d->m_page->settings()->setDeveloperExtrasEnabled(false);

Would be nice to make this call implicit.
Comment 3 Konrad Piascik 2012-11-21 14:11:30 PST 
(In reply to comment #2)
> (From update of attachment 175519 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175519&action=review
> 
> LGTM.
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:5223
> > +    d->setPreventsScreenDimming(true);
> 
> Seems like setPreventScreenDimming is the better name, but you are just using this API.
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:5230
> > +        d->m_page->settings()->setDeveloperExtrasEnabled(false);
> 
> Would be nice to make this call implicit.

I'll work on a follow-up patch to fix the API.
Comment 4 WebKit Review Bot 2012-11-21 15:02:06 PST 
Comment on attachment 175519 [details]
Patch

Clearing flags on attachment: 175519

Committed r135441: <http://trac.webkit.org/changeset/135441>
Comment 5 WebKit Review Bot 2012-11-21 15:02:10 PST 
All reviewed patches have been landed.  Closing bug.