Bug 102942 - [Qt] Compiling against QtWebkit API requires QT_DLL to be defined
Summary: [Qt] Compiling against QtWebkit API requires QT_DLL to be defined
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Hausmann
URL:
Keywords:
Depends on:
Blocks: 76773
  Show dependency treegraph
 
Reported: 2012-11-21 07:34 PST by Simon Hausmann
Modified: 2022-02-28 04:05 PST (History)
4 users (show)

See Also:


Attachments
Patch (4.47 KB, patch)
2012-11-21 07:44 PST, Simon Hausmann
vestbo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2012-11-21 07:34:14 PST
The fact that QT_DLL is required for the correct import/export macros breaks the build of applications against QtWebKit when using cmake.

See also https://bugreports.qt-project.org/browse/QTBUG-28043
Comment 1 Simon Hausmann 2012-11-21 07:44:28 PST
Created attachment 175445 [details]
Patch
Comment 2 Tor Arne Vestbø 2012-11-21 08:17:31 PST
Comment on attachment 175445 [details]
Patch

lgtm
Comment 3 Simon Hausmann 2012-11-23 03:30:35 PST
Committed r135585: <http://trac.webkit.org/changeset/135585>