Bug 102907 - [GTK] TargetFrame and innerNodeFrame confused
Summary: [GTK] TargetFrame and innerNodeFrame confused
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on: 98139
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-21 02:26 PST by Allan Sandfeld Jensen
Modified: 2013-05-16 08:18 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.46 KB, patch)
2012-11-21 02:54 PST, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-11-21 02:26:35 PST
While trying to clarify the point returned by HitTestResult, I have gone through all the call-sites using the point, and have noticed what I can only assume are errors in webkithittestresult.cpp.

First of all you use targetFrame instead of the frame of the innernode to translate to window coordinates. This is likely wrong since targetframe is the frame the link your are hovering will be opened in (open link in different frame/open link in new window feature). 

Secondly your fall-back logic while probably not necessary uses the point in innerNodeFrame, it should probably instead use the point in mainFrame instead and translate from the mainframe. Alternatively you can always translate from the main-frame coordinates once the patch for bug #98139 lands.
Comment 1 Allan Sandfeld Jensen 2012-11-21 02:54:39 PST
Created attachment 175397 [details]
Patch
Comment 2 Martin Robinson 2013-05-16 07:58:09 PDT
Comment on attachment 175397 [details]
Patch

Thanks!
Comment 3 Allan Sandfeld Jensen 2013-05-16 08:18:33 PDT
Comment on attachment 175397 [details]
Patch

Clearing flags on attachment: 175397

Committed r150182: <http://trac.webkit.org/changeset/150182>
Comment 4 Allan Sandfeld Jensen 2013-05-16 08:18:38 PDT
All reviewed patches have been landed.  Closing bug.