Bug 102835 - When calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet
Summary: When calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-20 13:59 PST by Tony Chang
Modified: 2012-11-20 17:08 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.69 KB, patch)
2012-11-20 14:03 PST, Tony Chang
no flags Details | Formatted Diff | Diff
Patch for landing (3.83 KB, patch)
2012-11-20 14:23 PST, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-11-20 13:59:07 PST
When calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet
Comment 1 Tony Chang 2012-11-20 14:03:25 PST
Created attachment 175273 [details]
Patch
Comment 2 Ojan Vafai 2012-11-20 14:17:49 PST
Comment on attachment 175273 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175273&action=review

> Source/WebCore/ChangeLog:8
> +        After r135082, there's an ASSERT that assumes that we only pass in addUserSheet.

I think this sentence is missing a few words. I'm not sure what it's trying to say.
Comment 3 Tony Chang 2012-11-20 14:23:55 PST
Created attachment 175278 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-11-20 14:51:17 PST
Comment on attachment 175278 [details]
Patch for landing

Clearing flags on attachment: 175278

Committed r135316: <http://trac.webkit.org/changeset/135316>
Comment 5 WebKit Review Bot 2012-11-20 14:51:21 PST
All reviewed patches have been landed.  Closing bug.