Bug 102523 - Rebaseline run-binding-test
Summary: Rebaseline run-binding-test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Byungwoo Lee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-16 08:34 PST by Byungwoo Lee
Modified: 2012-11-16 12:50 PST (History)
5 users (show)

See Also:


Attachments
Patch (6.02 KB, patch)
2012-11-16 08:36 PST, Byungwoo Lee
no flags Details | Formatted Diff | Diff
Patch (6.02 KB, patch)
2012-11-16 08:49 PST, Byungwoo Lee
no flags Details | Formatted Diff | Diff
Patch (6.03 KB, patch)
2012-11-16 09:27 PST, Byungwoo Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Byungwoo Lee 2012-11-16 08:34:31 PST
bindings tests are failed after r101331
Extpected results need to be updated.
Comment 1 Byungwoo Lee 2012-11-16 08:36:47 PST
Created attachment 174695 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2012-11-16 08:44:01 PST
I don't understand how http://trac.webkit.org/changeset/101331 could cause this?
Comment 3 Byungwoo Lee 2012-11-16 08:47:24 PST
(In reply to comment #2)
> I don't understand how http://trac.webkit.org/changeset/101331 could cause this?

Oops, It's bug number. r134931 is the right revision.
Comment 4 Byungwoo Lee 2012-11-16 08:49:30 PST
Created attachment 174698 [details]
Patch
Comment 5 WebKit Review Bot 2012-11-16 09:09:35 PST
Comment on attachment 174698 [details]
Patch

Rejecting attachment 174698 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
onentRefAccessibleAtPoint(AtkComponent*, gint, gint, AtkCoordType)':
Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceComponent.cpp:74: error: 'class WebCore::AccessibilityObject' has no member named 'wrapper'
Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceComponent.cpp:75: error: 'class WebCore::AccessibilityObject' has no member named 'wrapper'
make: *** [out/Release/obj.target/webcore_remaining/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceComponent.o] Error 1

Full output: http://queues.webkit.org/results/14872198
Comment 6 Byungwoo Lee 2012-11-16 09:27:01 PST
Created attachment 174706 [details]
Patch
Comment 7 Byungwoo Lee 2012-11-16 09:27:47 PST
Comment on attachment 174706 [details]
Patch

uploaded again to commit.
Comment 8 WebKit Review Bot 2012-11-16 12:50:17 PST
Comment on attachment 174706 [details]
Patch

Clearing flags on attachment: 174706

Committed r134988: <http://trac.webkit.org/changeset/134988>
Comment 9 WebKit Review Bot 2012-11-16 12:50:21 PST
All reviewed patches have been landed.  Closing bug.