Bug 102489 - [chromium] move stubs from DRTTestRunner to TestRunner
Summary: [chromium] move stubs from DRTTestRunner to TestRunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks: 92319
  Show dependency treegraph
 
Reported: 2012-11-16 05:34 PST by jochen
Modified: 2012-11-16 15:06 PST (History)
3 users (show)

See Also:


Attachments
Patch (25.73 KB, patch)
2012-11-16 05:35 PST, jochen
no flags Details | Formatted Diff | Diff
Patch for landing (24.32 KB, patch)
2012-11-16 11:46 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-11-16 05:34:54 PST
[chromium] move stubs from DRTTestRunner to TestRunner
Comment 1 jochen 2012-11-16 05:35:46 PST
Created attachment 174654 [details]
Patch
Comment 2 Adam Barth 2012-11-16 09:30:08 PST
Comment on attachment 174654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174654&action=review

> Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:79
> +    m_delegate->printMessage("CONSOLE MESSAGE: JavaScript ERROR: unknown method called on DRTTestRunner\n");

DRTTestRunner?  Perhaps "TestRunner" ?
Comment 3 jochen 2012-11-16 11:46:49 PST
Created attachment 174734 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-11-16 15:06:09 PST
Comment on attachment 174734 [details]
Patch for landing

Clearing flags on attachment: 174734

Committed r135008: <http://trac.webkit.org/changeset/135008>
Comment 5 WebKit Review Bot 2012-11-16 15:06:14 PST
All reviewed patches have been landed.  Closing bug.