Bug 102108 - Missing NodeRenderStyle.h include in WebCore/html/TextFieldInputType.cpp
: Missing NodeRenderStyle.h include in WebCore/html/TextFieldInputType.cpp
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Xianzhu Wang
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-13 10:57 PST by Xianzhu Wang
Modified: 2012-11-13 15:54 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.17 KB, patch)
2012-11-13 11:24 PST, Xianzhu Wang
no flags Details | Formatted Diff | Diff
rebased (1.18 KB, patch)
2012-11-13 12:03 PST, Xianzhu Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-11-13 10:57:31 PST
Node::renderStyle() is declared in Node.h, defined as an inline function in NodeRenderStyle.h. TextFieldInputType.cpp doesn't include NodeRenderStyle.h but uses Node::renderStyle(). This causes link error on a Chromium bot (http://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/1238/steps/compile/logs/stdio/text).
Comment 1 Xianzhu Wang 2012-11-13 11:24:42 PST
Created attachment 173932 [details]
Patch
Comment 2 Adam Barth 2012-11-13 11:41:49 PST
Comment on attachment 173932 [details]
Patch

ok
Comment 3 WebKit Review Bot 2012-11-13 11:57:02 PST
Comment on attachment 173932 [details]
Patch

Rejecting attachment 173932 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14818667
Comment 4 Xianzhu Wang 2012-11-13 12:03:01 PST
Created attachment 173944 [details]
rebased
Comment 5 Xianzhu Wang 2012-11-13 15:54:15 PST
Comment on attachment 173944 [details]
rebased

Clearing flags on attachment: 173944

Committed r134500: <http://trac.webkit.org/changeset/134500>
Comment 6 Xianzhu Wang 2012-11-13 15:54:17 PST
All reviewed patches have been landed.  Closing bug.