Bug 101732 - Web Inspector: [Canvas] render canvas log as a grid.
Summary: Web Inspector: [Canvas] render canvas log as a grid.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-09 02:19 PST by Pavel Feldman
Modified: 2012-11-09 03:34 PST (History)
9 users (show)

See Also:

Attachments
Patch (13.01 KB, patch)
2012-11-09 02:20 PST, Pavel Feldman 		vsevik: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-11-09 02:19:24 PST 
Simple UI tweak.
Comment 1 Pavel Feldman 2012-11-09 02:20:56 PST 
Created attachment 173247 [details]
Patch
Comment 2 Andrey Adaikin 2012-11-09 02:26:49 PST 
Comment on attachment 173247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173247&action=review

> Source/WebCore/inspector/front-end/CanvasProfileView.js:270
> +        var fragment = document.createDocumentFragment();

this is not used

> Source/WebCore/inspector/front-end/CanvasProfileView.js:274
> +        var lastNode = this.rootNode().children[calls.length - 1];

can lastNode be NULL? (there used to be a NULL check here)
Comment 3 Pavel Feldman 2012-11-09 03:34:31 PST 
Committed r134045: <http://trac.webkit.org/changeset/134045>