RESOLVED FIXED101691
[V8] Clean up header includes and ifdefs in V8GCController 
https://bugs.webkit.org/show_bug.cgi?id=101691
Summary [V8] Clean up header includes and ifdefs in V8GCController
Adam Barth
Reported 2012-11-08 19:22:30 PST
[V8] Clean up header includes and ifdefs in V8GCController
Attachments
Patch (3.53 KB, patch)
2012-11-08 19:23 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-11-08 19:23:08 PST
Created attachment 173178 [details] Patch
Kentaro Hara
Comment 2 2012-11-09 02:01:49 PST
Comment on attachment 173178 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173178&action=review > Source/WebCore/bindings/v8/V8GCController.cpp:-298 > -#if PLATFORM(CHROMIUM) What's the rationale to remove this macro?
Adam Barth
Comment 3 2012-11-09 10:30:19 PST
> What's the rationale to remove this macro? Qt and GTK used to have an option to build with V8. These ifdefs were added to support that, but they no longer have that option.
Kentaro Hara
Comment 4 2012-11-09 20:15:21 PST
Comment on attachment 173178 [details] Patch > Qt and GTK used to have an option to build with V8. These ifdefs were added to support that, but they no longer have that option. OK. BTW, then it seems that UseV8.cmake is no longer needed. UseV8.cmake already lacks a bunch of V8 binding files and it looks like they have not been maintained.
Adam Barth
Comment 5 2012-11-10 10:20:42 PST
Comment on attachment 173178 [details] Patch Ok. We should delete it so we don't spend energy maintaining it.
WebKit Review Bot
Comment 6 2012-11-10 10:25:41 PST
Comment on attachment 173178 [details] Patch Clearing flags on attachment: 173178 Committed r134159: <http://trac.webkit.org/changeset/134159>
WebKit Review Bot
Comment 7 2012-11-10 10:25:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.