Bug 101684 – REGRESSION(r133984): windows build error. (Requested by hayato on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/133984 broke the build:
windows build error. (Requested by hayato on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 173169 [details]
ROLLOUT of r133984

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Hayato Ito]

Windows build on canary started to fail.

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/builds/32442/steps/compile/logs/stdio

13>ClCompile:
13>  IDBAbortOnCorruptTest.cpp
13>  IDBDatabaseBackendTest.cpp
13>  IDBRequestTest.cpp
13>C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WTF\wtf/PassRefPtr.h(53): error C2027: use of undefined type 'WebCore::DOMStringList'
13>          C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WebCore\Modules\indexeddb\IDBDatabaseBackendInterface.h(37) : see declaration of 'WebCore::DOMStringList'
13>          C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WTF\wtf/PassRefPtr.h(68) : see reference to function template instantiation 'void WTF::derefIfNotNull<T>(T *)' being compiled
13>          with
13>          [
13>              T=WebCore::DOMStringList
13>          ]
13>          C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WTF\wtf/PassRefPtr.h(68) : while compiling class template member function 'WTF::PassRefPtr<T>::~PassRefPtr(void)'
13>          with
13>          [
13>              T=WebCore::DOMStringList
13>          ]
13>          tests\IDBAbortOnCorruptTest.cpp(55) : see reference to class template instantiation 'WTF::PassRefPtr<T>' being compiled
13>          with
13>          [
13>              T=WebCore::DOMStringList
13>          ]

[WebKit Review Bot]

Comment on attachment 173169 [details]
ROLLOUT of r133984

Clearing flags on attachment: 173169

Committed r133994: <http://trac.webkit.org/changeset/133994>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Alec Flett]

I think I got the correct fix in bug 100426, just an #include order issue. trying another commit-queue landing from there..