Bug 101385 - Add new gesture type, LongTap, which is basically the completion of a GestureLongPress
Summary: Add new gesture type, LongTap, which is basically the completion of a Gesture...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Varun Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-06 13:04 PST by Varun Jain
Modified: 2012-11-07 10:37 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.12 KB, patch)
2012-11-06 13:05 PST, Varun Jain
no flags Details | Formatted Diff | Diff
Patch (7.17 KB, patch)
2012-11-06 14:54 PST, Varun Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Varun Jain 2012-11-06 13:04:08 PST
Add new gesture type, LongTap, which is basically the completion of a GestureLongPress
Comment 1 Varun Jain 2012-11-06 13:05:45 PST
Created attachment 172634 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-06 13:08:52 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2012-11-06 13:55:14 PST
Comment on attachment 172634 [details]
Patch

Attachment 172634 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14728942
Comment 4 Varun Jain 2012-11-06 14:54:34 PST
Created attachment 172657 [details]
Patch
Comment 5 Varun Jain 2012-11-06 14:55:00 PST
Fixed cr-linux build
Comment 6 Adam Barth 2012-11-06 14:58:10 PST
Comment on attachment 172657 [details]
Patch

API change LGTM
Comment 7 WebKit Review Bot 2012-11-07 10:37:45 PST
Comment on attachment 172657 [details]
Patch

Clearing flags on attachment: 172657

Committed r133780: <http://trac.webkit.org/changeset/133780>
Comment 8 WebKit Review Bot 2012-11-07 10:37:49 PST
All reviewed patches have been landed.  Closing bug.