Bug 101324 - [Qt] We might want to disable all fast/dom/shadow tests.
Summary: [Qt] We might want to disable all fast/dom/shadow tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-06 01:40 PST by Shinya Kawanaka
Modified: 2012-11-06 04:09 PST (History)
2 users (show)

See Also:

Attachments
Patch (8.30 KB, patch)
2012-11-06 01:45 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-11-06 01:40:49 PST 
Since Qt does not enable SHADOW_DOM, a lot of tests in fast/dom/shadow are failing. Also, now a lot of tests is being added into it.
Maybe it would be better to skip all fast/dom/shadow tests until Qt enables SHADOW_DOM flag.
Comment 1 Shinya Kawanaka 2012-11-06 01:45:59 PST 
Created attachment 172522 [details]
Patch
Comment 2 Csaba Osztrogonác 2012-11-06 01:47:39 PST 
Comment on attachment 172522 [details]
Patch

good idea, r=me.
Comment 3 WebKit Review Bot 2012-11-06 01:52:57 PST 
Attachment 172522 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/qt/TestExpectations:326:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Csaba Osztrogonác 2012-11-06 04:09:47 PST 
Comment on attachment 172522 [details]
Patch

Clearing flags on attachment: 172522

Committed r133584: <http://trac.webkit.org/changeset/133584>
Comment 5 Csaba Osztrogonác 2012-11-06 04:09:52 PST 
All reviewed patches have been landed.  Closing bug.