RESOLVED FIXED 101247
Get rid of setCookieStoragePrivateBrowsingEnabled() 
https://bugs.webkit.org/show_bug.cgi?id=101247
Summary Get rid of setCookieStoragePrivateBrowsingEnabled()
Alexey Proskuryakov
Reported 2012-11-05 13:02:14 PST
This function is only implemented on Mac, and it's not needed, because we have sessions.
Attachments
proposed patch (16.29 KB, patch)
2012-11-05 13:17 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed patch (16.16 KB, patch)
2012-11-05 13:29 PST, Alexey Proskuryakov 		beidson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-11-05 13:17:59 PST
Created attachment 172386 [details] proposed patch
Alexey Proskuryakov
Comment 2 2012-11-05 13:29:01 PST
Created attachment 172390 [details] proposed patch Removed one erroneous line from ChangeLog.
Brady Eidson
Comment 3 2012-11-05 14:04:44 PST
Comment on attachment 172390 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=172390&action=review > Source/WebCore/platform/network/CookieStorage.h:33 > +// These are always observing main cookie storage, even when in private browsing mode. nit - "...observing *the* main cookie storage", or "...observing *the* main cookie store"
Alexey Proskuryakov
Comment 4 2012-11-05 14:08:16 PST
Committed <http://trac.webkit.org/changeset/133524>.
Note You need to log in before you can comment on or make changes to this bug.