Bug 101191 - [V8] Dispose() and Clear() should be always coupled for safety
Summary: [V8] Dispose() and Clear() should be always coupled for safety
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-05 01:01 PST by Kentaro Hara
Modified: 2012-11-05 08:14 PST (History)
3 users (show)

See Also:


Attachments
Patch (7.67 KB, patch)
2012-11-05 01:53 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-11-05 01:01:35 PST
Clear() is not mandatory. However, to avoid misusing already disposed wrappers, Clear() should be always called just after Dispose().
Comment 1 Kentaro Hara 2012-11-05 01:53:52 PST
Created attachment 172295 [details]
Patch
Comment 2 Adam Barth 2012-11-05 07:43:07 PST
Comment on attachment 172295 [details]
Patch

ok
Comment 3 WebKit Review Bot 2012-11-05 08:14:52 PST
Comment on attachment 172295 [details]
Patch

Clearing flags on attachment: 172295

Committed r133479: <http://trac.webkit.org/changeset/133479>
Comment 4 WebKit Review Bot 2012-11-05 08:14:56 PST
All reviewed patches have been landed.  Closing bug.