Bug 101146 - Baseline JIT should use structure watchpoints whenever possible
Summary: Baseline JIT should use structure watchpoints whenever possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 101147
  Show dependency tree / graph
 
Reported: 2012-11-03 02:51 PDT by Filip Pizlo
Modified: 2012-11-04 19:41 PST (History)
8 users (show)

See Also:

Attachments
the patch (13.83 KB, patch)
2012-11-03 02:56 PDT, Filip Pizlo 		sam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (13.91 KB, patch)
2012-11-04 01:03 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-11-03 02:51:20 PDT 
Patch forthcoming
Comment 1 Filip Pizlo 2012-11-03 02:56:17 PDT 
Created attachment 172214 [details]
the patch
Comment 2 WebKit Review Bot 2012-11-03 02:59:06 PDT 
Attachment 172214 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/jit/JIT.h:470:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/jit/JIT.h:471:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2012-11-03 03:21:51 PDT 
Comment on attachment 172214 [details]
the patch

Attachment 172214 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14717214
Comment 4 Filip Pizlo 2012-11-04 01:03:56 PST 
Created attachment 172241 [details]
patch for landing

Checking if Windows builds now.
Comment 5 Filip Pizlo 2012-11-04 19:41:33 PST 
Landed in http://trac.webkit.org/changeset/133430