Bug 101126 - Decouple Attr logic from ElementAttributeData.
Summary: Decouple Attr logic from ElementAttributeData.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-02 16:50 PDT by Andreas Kling
Modified: 2012-11-05 10:07 PST (History)
2 users (show)

See Also:

Attachments
Cool patch (22.51 KB, patch)
2012-11-03 03:46 PDT, Andreas Kling 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Cooler patch (22.88 KB, patch)
2012-11-03 03:59 PDT, Andreas Kling 		koivisto: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Coolest patch (23.02 KB, patch)
2012-11-03 04:16 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-11-02 16:50:27 PDT 
Attr is per-Element, and one ElementAttributeData can be used by multiple Elements.
Hence, Attr should be managed by Element instead of ElementAttributeData.
Comment 1 Andreas Kling 2012-11-03 03:46:31 PDT 
Created attachment 172216 [details]
Cool patch
Comment 2 Early Warning System Bot 2012-11-03 03:56:10 PDT 
Comment on attachment 172216 [details]
Cool patch

Attachment 172216 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14726117
Comment 3 Early Warning System Bot 2012-11-03 03:58:22 PDT 
Comment on attachment 172216 [details]
Cool patch

Attachment 172216 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14726116
Comment 4 Andreas Kling 2012-11-03 03:59:03 PDT 
Created attachment 172217 [details]
Cooler patch
Comment 5 Antti Koivisto 2012-11-03 04:02:30 PDT 
Comment on attachment 172216 [details]
Cool patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172216&action=review

> Source/WebCore/dom/Node.h:243
> +    bool hasSyntheticAttrChildNodes() const { return getFlag(HasSyntheticAttrChildNodesFlag); }
> +    void setHasSyntheticAttrChildNodes(bool f) { setFlag(f, HasSyntheticAttrChildNodesFlag); }

f?!

I like the use of 'synthetic' here.
Comment 6 Early Warning System Bot 2012-11-03 04:11:14 PDT 
Comment on attachment 172217 [details]
Cooler patch

Attachment 172217 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14721175
Comment 7 Early Warning System Bot 2012-11-03 04:12:22 PDT 
Comment on attachment 172217 [details]
Cooler patch

Attachment 172217 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14721176
Comment 8 Andreas Kling 2012-11-03 04:16:43 PDT 
Created attachment 172219 [details]
Coolest patch
Comment 9 WebKit Review Bot 2012-11-03 04:56:21 PDT 
Comment on attachment 172219 [details]
Coolest patch

Clearing flags on attachment: 172219

Committed r133394: <http://trac.webkit.org/changeset/133394>
Comment 10 WebKit Review Bot 2012-11-03 04:56:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Andreas Kling 2012-11-05 10:07:28 PST 
Committed r133492: <http://trac.webkit.org/changeset/133492>