Bug 100916 - Web Inspector: No "Save Heap Snapshot" option after canceling save to file dialog.
Summary: Web Inspector: No "Save Heap Snapshot" option after canceling save to file di...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: eustas.bug
URL: http://code.google.com/p/chromium/iss...
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-31 22:19 PDT by eustas.bug
Modified: 2012-11-25 22:23 PST (History)
13 users (show)

See Also:


Attachments
Patch (8.81 KB, patch)
2012-10-31 23:28 PDT, eustas.bug
no flags Details | Formatted Diff | Diff
Patch (8.70 KB, patch)
2012-11-01 04:57 PDT, eustas.bug
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description eustas.bug 2012-10-31 22:19:32 PDT
Steps to reproduce:
1. Take heap snapshot.
2. Right click on the snapshot, "Save Heap Snapshot".
3. Click "CANCEL" on the save to file dialog.
4. Right click on the snapshot.

Result: "Save Heap Snapshot" menu item do not appear.
Comment 1 eustas.bug 2012-10-31 23:28:42 PDT
Created attachment 171777 [details]
Patch
Comment 2 Yury Semikhatsky 2012-11-01 04:16:29 PDT
Comment on attachment 171777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171777&action=review

> LayoutTests/inspector/profiler/heap-snapshot-loader.html:141
> +                InspectorFrontendHost.save = function saveMock(url, data)

Use InspectorTest.override instead.
Comment 3 eustas.bug 2012-11-01 04:57:48 PDT
Created attachment 171816 [details]
Patch
Comment 4 eustas.bug 2012-11-01 04:59:59 PDT
Comment on attachment 171777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171777&action=review

>> LayoutTests/inspector/profiler/heap-snapshot-loader.html:141
>> +                InspectorFrontendHost.save = function saveMock(url, data)
> 
> Use InspectorTest.override instead.

Done
Comment 5 Andrey Kosyakov 2012-11-23 03:32:08 PST
Committed r135586: <http://trac.webkit.org/changeset/135586>