Bug 100644 - Don't expose implementation details of StylePropertySet storage.
Summary: Don't expose implementation details of StylePropertySet storage.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-29 02:37 PDT by Andreas Kling
Modified: 2012-10-29 04:44 PDT (History)
13 users (show)

See Also:

Attachments
A patch? (16.47 KB, patch)
2012-10-29 02:38 PDT, Andreas Kling 		koivisto: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (21.32 KB, patch)
2012-10-29 04:07 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-10-29 02:37:28 PDT 
Don't expose implementation details of StylePropertySet storage.
Comment 1 Andreas Kling 2012-10-29 02:38:47 PDT 
Created attachment 171185 [details]
A patch?
Comment 2 Antti Koivisto 2012-10-29 02:50:47 PDT 
Comment on attachment 171185 [details]
A patch?

View in context: https://bugs.webkit.org/attachment.cgi?id=171185&action=review

Nice!

> Source/WebCore/css/StylePropertySet.h:57
> +    class PropertyReference {

StylePropertySet::PropertyReference sounds bit redundant but I don't have better suggestions.
Comment 3 EFL EWS Bot 2012-10-29 02:51:48 PDT 
Comment on attachment 171185 [details]
A patch?

Attachment 171185 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14618680
Comment 4 WebKit Review Bot 2012-10-29 03:02:12 PDT 
Comment on attachment 171185 [details]
A patch?

Attachment 171185 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14629072
Comment 5 Peter Beverloo (cr-android ews) 2012-10-29 03:12:29 PDT 
Comment on attachment 171185 [details]
A patch?

Attachment 171185 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14576041
Comment 6 Andreas Kling 2012-10-29 04:07:42 PDT 
Created attachment 171197 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-10-29 04:44:49 PDT 
Comment on attachment 171197 [details]
Patch for landing

Clearing flags on attachment: 171197

Committed r132786: <http://trac.webkit.org/changeset/132786>
Comment 8 WebKit Review Bot 2012-10-29 04:44:54 PDT 
All reviewed patches have been landed.  Closing bug.