RESOLVED FIXED 100435
[chromium] Add implicit conversions between WebFloatPoint and gfx::PointF 
https://bugs.webkit.org/show_bug.cgi?id=100435
Summary [chromium] Add implicit conversions between WebFloatPoint and gfx::PointF
Dana Jansens
Reported 2012-10-25 17:08:42 PDT
[chromium] Add implicit conversions between WebFloatPoint and gfx::PointF
Attachments
Patch (1.76 KB, patch)
2012-10-25 17:09 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.79 KB, patch)
2012-10-26 11:33 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-10-25 17:09:31 PDT
Created attachment 170768 [details] Patch
WebKit Review Bot
Comment 2 2012-10-25 17:11:04 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Dana Jansens
Comment 3 2012-10-25 19:59:44 PDT
jamesr@ please take a look
WebKit Review Bot
Comment 4 2012-10-26 11:27:45 PDT
Comment on attachment 170768 [details] Patch Rejecting attachment 170768 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/Platform/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14609146
Dana Jansens
Comment 5 2012-10-26 11:33:55 PDT
Created attachment 170969 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-10-26 12:15:53 PDT
Comment on attachment 170969 [details] Patch for landing Clearing flags on attachment: 170969 Committed r132683: <http://trac.webkit.org/changeset/132683>
WebKit Review Bot
Comment 7 2012-10-26 12:15:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.