Bug 100435 - [chromium] Add implicit conversions between WebFloatPoint and gfx::PointF
Summary: [chromium] Add implicit conversions between WebFloatPoint and gfx::PointF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-25 17:08 PDT by Dana Jansens
Modified: 2012-10-26 12:15 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2012-10-25 17:09 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Patch for landing (1.79 KB, patch)
2012-10-26 11:33 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-10-25 17:08:42 PDT 
[chromium] Add implicit conversions between WebFloatPoint and gfx::PointF
Comment 1 Dana Jansens 2012-10-25 17:09:31 PDT 
Created attachment 170768 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-25 17:11:04 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Dana Jansens 2012-10-25 19:59:44 PDT 
jamesr@ please take a look
Comment 4 WebKit Review Bot 2012-10-26 11:27:45 PDT 
Comment on attachment 170768 [details]
Patch

Rejecting attachment 170768 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/Platform/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14609146
Comment 5 Dana Jansens 2012-10-26 11:33:55 PDT 
Created attachment 170969 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-10-26 12:15:53 PDT 
Comment on attachment 170969 [details]
Patch for landing

Clearing flags on attachment: 170969

Committed r132683: <http://trac.webkit.org/changeset/132683>
Comment 7 WebKit Review Bot 2012-10-26 12:15:57 PDT 
All reviewed patches have been landed.  Closing bug.