Bug 100340 - Web Inspector: NMI instrument InspectorDebuggerAgent. It uses a lot of memory on heavy js sites because it keeps all the scripts in a map
Summary: Web Inspector: NMI instrument InspectorDebuggerAgent. It uses a lot of memory...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-25 00:09 PDT by Ilya Tikhonovsky
Modified: 2012-10-25 07:52 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.19 KB, patch)
2012-10-25 00:36 PDT, Ilya Tikhonovsky 		yurys: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
for try bots (5.22 KB, patch)
2012-10-25 00:56 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
for try bots (5.48 KB, patch)
2012-10-25 01:12 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-10-25 00:09:35 PDT 
EOM
Comment 1 Ilya Tikhonovsky 2012-10-25 00:36:35 PDT 
Created attachment 170571 [details]
Patch
Comment 2 Early Warning System Bot 2012-10-25 00:44:53 PDT 
Comment on attachment 170571 [details]
Patch

Attachment 170571 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14552522
Comment 3 Early Warning System Bot 2012-10-25 00:45:12 PDT 
Comment on attachment 170571 [details]
Patch

Attachment 170571 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14566512
Comment 4 Yury Semikhatsky 2012-10-25 00:49:26 PDT 
Comment on attachment 170571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170571&action=review

> Source/WebCore/ChangeLog:3
> +        Web Inspector: NMI instrument InspectorDebuggerAgent. It uses a lot of memory on heavy js sites because it keeps all the scripts in a map.

I'm wondering if the scripts are the same as in VM or we store a copy of them in the debugger agent.
Comment 5 Ilya Tikhonovsky 2012-10-25 00:56:00 PDT 
Created attachment 170576 [details]
for try bots
Comment 6 Build Bot 2012-10-25 01:04:37 PDT 
Comment on attachment 170571 [details]
Patch

Attachment 170571 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14562510
Comment 7 WebKit Review Bot 2012-10-25 01:05:29 PDT 
Comment on attachment 170571 [details]
Patch

Attachment 170571 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14544534
Comment 8 Early Warning System Bot 2012-10-25 01:06:09 PDT 
Comment on attachment 170576 [details]
for try bots

Attachment 170576 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14552531
Comment 9 Early Warning System Bot 2012-10-25 01:07:00 PDT 
Comment on attachment 170576 [details]
for try bots

Attachment 170576 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14543574
Comment 10 Ilya Tikhonovsky 2012-10-25 01:12:12 PDT 
Created attachment 170580 [details]
for try bots
Comment 11 EFL EWS Bot 2012-10-25 02:17:54 PDT 
Comment on attachment 170571 [details]
Patch

Attachment 170571 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14552545
Comment 12 Ilya Tikhonovsky 2012-10-25 03:54:10 PDT 
Committed r132466: <http://trac.webkit.org/changeset/132466>