RESOLVED FIXED100250
[BlackBerry] Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry 
https://bugs.webkit.org/show_bug.cgi?id=100250
Summary [BlackBerry] Rename GeolocationControllerClientBlackBerry to GeolocationClien...
otcheung
Reported 2012-10-24 07:42:05 PDT
To prevent confusion. GeolocationControllerClientBlackBerry has nothing to do with GeolocationController.
Attachments
Patch (20.22 KB, patch)
2012-10-24 07:53 PDT, otcheung 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
otcheung
Comment 1 2012-10-24 07:53:56 PDT
Created attachment 170394 [details] Patch
Rob Buis
Comment 2 2012-10-24 07:56:21 PDT
Comment on attachment 170394 [details] Patch LGTM.
WebKit Review Bot
Comment 3 2012-10-24 07:59:12 PDT
Attachment 170394 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/..." exit_code: 1 Source/WebKit/blackberry/WebCoreSupport/GeolocationClientBlackBerry.cpp:89: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/GeolocationClientBlackBerry.cpp:92: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/GeolocationClientBlackBerry.h:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 4 2012-10-24 08:30:40 PDT
Comment on attachment 170394 [details] Patch Clearing flags on attachment: 170394 Committed r132360: <http://trac.webkit.org/changeset/132360>
WebKit Review Bot
Comment 5 2012-10-24 08:30:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.