Bug 100250 - [BlackBerry] Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
Summary: [BlackBerry] Rename GeolocationControllerClientBlackBerry to GeolocationClien...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-24 07:42 PDT by otcheung
Modified: 2012-10-24 08:30 PDT (History)
6 users (show)

See Also:

Attachments
Patch (20.22 KB, patch)
2012-10-24 07:53 PDT, otcheung 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description otcheung 2012-10-24 07:42:05 PDT 
To prevent confusion. GeolocationControllerClientBlackBerry has nothing to do with GeolocationController.
Comment 1 otcheung 2012-10-24 07:53:56 PDT 
Created attachment 170394 [details]
Patch
Comment 2 Rob Buis 2012-10-24 07:56:21 PDT 
Comment on attachment 170394 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2012-10-24 07:59:12 PDT 
Attachment 170394 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/..." exit_code: 1
Source/WebKit/blackberry/WebCoreSupport/GeolocationClientBlackBerry.cpp:89:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebCoreSupport/GeolocationClientBlackBerry.cpp:92:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebCoreSupport/GeolocationClientBlackBerry.h:48:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Review Bot 2012-10-24 08:30:40 PDT 
Comment on attachment 170394 [details]
Patch

Clearing flags on attachment: 170394

Committed r132360: <http://trac.webkit.org/changeset/132360>
Comment 5 WebKit Review Bot 2012-10-24 08:30:44 PDT 
All reviewed patches have been landed.  Closing bug.