Bug 100200 - [chromium] Respect image orientation in image dragging code
Summary: [chromium] Respect image orientation in image dragging code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
Depends on:
Blocks: 100191
  Show dependency tree / graph
 
Reported: 2012-10-23 22:41 PDT by Nico Weber
Modified: 2012-10-24 11:03 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.80 KB, patch)
2012-10-23 22:42 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch (3.79 KB, patch)
2012-10-24 09:12 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2012-10-23 22:41:16 PDT 
[chromium] Respect image orientation in image dragging code
Comment 1 Nico Weber 2012-10-23 22:42:50 PDT 
Created attachment 170318 [details]
Patch
Comment 2 Nico Weber 2012-10-23 22:46:42 PDT 
Looks like Tony reviewed code in this area recently, and Varun wrote code in this area recently. Please take a look.

(Varun: image sizes are in pixels, so I don't need to do anything special for this to be correct in hidpi, is that right?)
Comment 3 Nico Weber 2012-10-24 09:12:59 PDT 
Created attachment 170412 [details]
Patch
Comment 4 Varun Jain 2012-10-24 10:49:38 PDT 
(In reply to comment #2)
> Looks like Tony reviewed code in this area recently, and Varun wrote code in this area recently. Please take a look.
> 
> (Varun: image sizes are in pixels, so I don't need to do anything special for this to be correct in hidpi, is that right?)

Yes. The device scale factor is applied later in DragClientImpl. So I think this should just work for hidpi.
Comment 5 WebKit Review Bot 2012-10-24 11:03:01 PDT 
Comment on attachment 170412 [details]
Patch

Clearing flags on attachment: 170412

Committed r132374: <http://trac.webkit.org/changeset/132374>
Comment 6 WebKit Review Bot 2012-10-24 11:03:05 PDT 
All reviewed patches have been landed.  Closing bug.