| Summary: | [BlackBerry] Missing some cookies in HTTP response header when set several cookies in one "Set-Cookie" header. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peter Wang <PeterHWang> | ||||||||
| Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | charles.wei, joenotcharles, kpiascik, mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
Attachment 169823 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1
Total errors found: 0 in 0 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 169825 [details]
Patch
Comment on attachment 169825 [details]
Patch
This looks good to me.
Comment on attachment 169825 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169825&action=review Please make the comment clearer first. > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:338 > + // If there are several "Set-Cookie" headers, we should combine the followed with headed. "following ones with this header" is what is meant here? (In reply to comment #4) > (From update of attachment 169825 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169825&action=review > > Please make the comment clearer first. > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:338 > > + // If there are several "Set-Cookie" headers, we should combine the followed with headed. > > "following ones with this header" is what is meant here? ok. sorry. Created attachment 169857 [details]
Patch
Comment on attachment 169857 [details]
Patch
I would have liked to see a test with this. Not sure how though.
Comment on attachment 169857 [details] Patch Clearing flags on attachment: 169857 Committed r132177: <http://trac.webkit.org/changeset/132177> All reviewed patches have been landed. Closing bug. |
Created attachment 169823 [details] test case Visit the attached test case, from Inspector we can see we've missed several cookies in response. I've checked this problem. The code of Inspector is ok, we really missed them when we made response headers.