Bug 99944

Summary:

Remove Page::javaScriptURLsAreAllowed setting.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore Misc.

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

koivisto, sam, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	andersca: review-, andersca: commit-queue-
Patch v2	none

Description Andreas Kling 2012-10-21 16:33:51 PDT

This setting doesn't have any clients anymore, let's remove it.

Comment 1 Andreas Kling 2012-10-21 16:38:09 PDT

Created attachment 169817 [details]
Patch

Comment 2 Antti Koivisto 2012-10-21 16:39:29 PDT

Comment on attachment 169817 [details]
Patch

r=me

Comment 3 Anders Carlsson 2012-10-21 16:59:47 PDT

Comment on attachment 169817 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169817&action=review

> Source/WebKit/win/WebView.cpp:-6183
> -HRESULT WebView::setJavaScriptURLsAreAllowed(BOOL areAllowed)
> -{
> -    m_page->setJavaScriptURLsAreAllowed(areAllowed);
> -    return S_OK;
> -}
> -

Removing this will break the COM ABI. Just remove the implementation and have it return E_NOTIMPL instead.

Comment 4 Andreas Kling 2012-10-21 17:06:46 PDT

Created attachment 169819 [details]
Patch v2

Ok, let's not break the COM ABI.

Comment 5 WebKit Review Bot 2012-10-21 19:38:06 PDT

Comment on attachment 169819 [details]
Patch v2

Clearing flags on attachment: 169819

Committed r132023: <http://trac.webkit.org/changeset/132023>

Comment 6 WebKit Review Bot 2012-10-21 19:38:10 PDT

All reviewed patches have been landed.  Closing bug.