Bug 99889

Summary: HTML Parser should produce 8 bit strings for doctype, comment and tagName tokens
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: DOMAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch ggaren: review+

Michael Saboff
Reported 2012-10-19 16:44:21 PDT
This is to fill out the tokens that the HTML parser will create 8-bit AtomicStrings for to include doctype, comments and tagName's.
Attachments
Patch (14.90 KB, patch)
2012-10-19 16:57 PDT, Michael Saboff 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-10-19 16:57:01 PDT
Created attachment 169729 [details] Patch
Geoffrey Garen
Comment 2 2012-10-22 16:02:17 PDT
Comment on attachment 169729 [details] Patch r=me
Michael Saboff
Comment 3 2012-10-22 17:40:09 PDT
Committed r132165: <http://trac.webkit.org/changeset/132165>
Darin Adler
Comment 4 2012-10-22 17:46:13 PDT
Comment on attachment 169729 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169729&action=review > Source/WebCore/xml/parser/MarkupTokenBase.h:148 > + void beginEndTag(Vector<LChar, 32> characters) This argument type should be const Vector&, unless we want to copy a vector each time for some reason! > Source/WebCore/xml/parser/MarkupTokenBase.h:396 > + inline const String nameString() const The const in this return type “const String” doesn’t add value and should be removed. The inline keyword also adds nothing. Not sure why surrounding functions are using it.
Note You need to log in before you can comment on or make changes to this bug.