Bug 99888

Summary:

Update some AudioContext create() method names to latest Web Audio spec

Product:

WebKit

Reporter:

Chris Rogers <crogers>

Component:

New Bugs

Assignee:

Chris Rogers <crogers>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric.carlson, feature-media-reviews, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	abarth: review+

Description Chris Rogers 2012-10-19 16:44:20 PDT

Update some AudioContext create() method names to latest Web Audio spec

Comment 1 Chris Rogers 2012-10-19 16:52:43 PDT

Created attachment 169725 [details]
Patch

Comment 2 Adam Barth 2012-10-22 11:52:17 PDT

Do we want to use V8MeasureAs to measure the usage of the depreciated APIs?

Comment 3 Chris Rogers 2012-10-22 11:56:59 PDT

(In reply to comment #2)
> Do we want to use V8MeasureAs to measure the usage of the depreciated APIs?

Sure, I can add it under V8MeasureAs=LegacyWebAudioNoteOn
Or do you think we should add something like LegacyWebAudioCreate?

I'm afraid we'll soon run out of bits if we keep adding more :)

Comment 4 Adam Barth 2012-10-22 12:03:04 PDT

Maybe we should rename LegacyWebAudioNoteOn to just LegacyWebAudio and have them all share?

Comment 5 Chris Rogers 2012-10-22 12:15:53 PDT

(In reply to comment #4)
> Maybe we should rename LegacyWebAudioNoteOn to just LegacyWebAudio and have them all share?

Sound good, that's what I'll do...

Comment 6 Chris Rogers 2012-10-22 13:11:38 PDT

Committed r132125: <http://trac.webkit.org/changeset/132125>