Bug 99876

Summary: [V8] V8DOMWrapper should avoid using its document parameter (so we can remove it soon)
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, japhet, mihaip, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
typos fixed
haraken: review+
Updated run-bindings-tests results none

Adam Barth
Reported 2012-10-19 14:56:30 PDT
[V8] V8DOMWrapper should avoid using its document parameter (so we can remove it soon)
Attachments
Patch (9.12 KB, patch)
2012-10-19 14:58 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (13.75 KB, patch)
2012-10-19 15:11 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (16.37 KB, patch)
2012-10-19 15:23 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
typos fixed (16.37 KB, patch)
2012-10-19 15:25 PDT, Adam Barth 		haraken: review+
DetailsFormatted DiffDiff
Updated run-bindings-tests results (29.31 KB, patch)
2012-10-19 15:32 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-10-19 14:58:38 PDT
Created attachment 169701 [details] Patch
Adam Barth
Comment 2 2012-10-19 14:59:09 PDT
The use snuck into the function in http://trac.webkit.org/changeset/131167
Adam Barth
Comment 3 2012-10-19 15:11:28 PDT
Created attachment 169705 [details] Patch
Mihai Parparita
Comment 4 2012-10-19 15:13:49 PDT
Comment on attachment 169705 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169705&action=review > Source/WebCore/ChangeLog:9 > + isn't always a Document avaliable, so it doesn't make sense to pass it Typo: avaliable. > Source/WebCore/ChangeLog:10 > + as a parmater. We're just waiting for a V8 API change so we can still Typo: parmater.
Adam Barth
Comment 5 2012-10-19 15:23:18 PDT
Created attachment 169708 [details] Patch
Adam Barth
Comment 6 2012-10-19 15:25:06 PDT
Created attachment 169709 [details] typos fixed
Adam Barth
Comment 7 2012-10-19 15:32:32 PDT
Created attachment 169712 [details] Updated run-bindings-tests results
Kentaro Hara
Comment 8 2012-10-19 19:34:11 PDT
Comment on attachment 169709 [details] typos fixed Looks reasonable.
Adam Barth
Comment 9 2012-10-19 23:29:23 PDT
Committed r131981: <http://trac.webkit.org/changeset/131981>
Note You need to log in before you can comment on or make changes to this bug.