Bug 99869

Summary: Convert fast/sub-pixel/file-upload-control-at-fractional-offset-expected.html to ref test
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Tools / TestsAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, leviw, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch eric: review+

Emil A Eklund
Reported 2012-10-19 14:14:46 PDT
fast/sub-pixel/file-upload-control-at-fractional-offset-expected.html is currently a pixel test, convert it to a ref test instead.
Attachments
Patch (13.51 KB, patch)
2012-10-19 14:15 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch (13.51 KB, patch)
2012-10-19 14:16 PDT, Emil A Eklund 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-10-19 14:15:38 PDT
Created attachment 169691 [details] Patch
Emil A Eklund
Comment 2 2012-10-19 14:16:55 PDT
Created attachment 169692 [details] Patch
Emil A Eklund
Comment 3 2012-10-19 14:22:20 PDT
The patch doesn't apply as one of the images has an incorrect mime type.
Eric Seidel (no email)
Comment 4 2012-10-22 09:58:35 PDT
Comment on attachment 169692 [details] Patch It will now pass w/ or w/o subpixel enabled, no?
Emil A Eklund
Comment 5 2012-10-22 10:02:30 PDT
Yeah. It test that we are painting it aligned to device pixels so it'll pass regardless of whether the flag is on. If we where to break the alignment code and start painting form controls at subpixel bounds it'll break and that is why it was added.
Eric Seidel (no email)
Comment 6 2012-10-22 10:03:26 PDT
Comment on attachment 169692 [details] Patch OK.
Emil A Eklund
Comment 7 2012-10-22 10:19:20 PDT
Committed r132089: <http://trac.webkit.org/changeset/132089>
Note You need to log in before you can comment on or make changes to this bug.