Bug 99865

Summary:

Remove ::encode template specializations and just use overloads

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abecsi, cdumez, cmarcelo, menard, webkit.review.bot

Priority:

P2

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

99977

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	kling: review+

Anders Carlsson

Reported 2012-10-19 12:39:24 PDT

Remove ::encode template specializations and just use overloads

Attachments
Patch (38.94 KB, patch) 2012-10-19 12:41 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (39.51 KB, patch) 2012-10-20 10:57 PDT, Anders Carlsson	kling: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2012-10-19 12:41:25 PDT

Created attachment 169677 [details] Patch

Early Warning System Bot

Comment 2 2012-10-19 15:58:48 PDT

Comment on attachment 169677 [details] Patch Attachment 169677 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14471229

Anders Carlsson

Comment 3 2012-10-20 10:57:32 PDT

Created attachment 169769 [details] Patch

Anders Carlsson

Comment 4 2012-10-20 14:27:39 PDT

Committed r131990: <http://trac.webkit.org/changeset/131990>

Chris Dumez

Comment 5 2012-10-22 04:16:53 PDT

It appears the following test started failing after this patch: plugins/npruntime/remove-property.html Confirmed on both Mac port: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r131990%20(2531)/plugins/npruntime/remove-property-pretty-diff.html And EFL port: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r132058%20%284843%29/plugins/npruntime/remove-property-pretty-diff.html

Chris Dumez

Comment 6 2012-10-22 04:28:48 PDT

Also started failing on GTK port after this patch: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20WK2%20%28Tests%29/r131990%20%282682%29/results.html It seems the test is failing consistently so I filed a bug for it: Bug 99977.

Note You need to log in before you can comment on or make changes to this bug.