Bug 99859

Summary: [EFL] Optimize IntPoint::operator Evas_Point()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED INVALID    
Severity: Normal CC: andersca, gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review-

Chris Dumez
Reported 2012-10-19 11:17:26 PDT
IntPoint::operator Evas_Point() currently calls getters to access x and y members instead of accessing them directly. We should avoid these useless function calls.
Attachments
Patch (1.28 KB, patch)
2012-10-19 11:23 PDT, Chris Dumez 		andersca: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-19 11:23:21 PDT
Created attachment 169658 [details] Patch
Andreas Kling
Comment 2 2012-10-19 12:30:52 PDT
Comment on attachment 169658 [details] Patch This doesn't change anything, x() and y() are inline functions.
Anders Carlsson
Comment 3 2012-10-19 12:38:33 PDT
Comment on attachment 169658 [details] Patch Yup. This is such a slight optimization that it's not an optimization at all!
Chris Dumez
Comment 4 2012-10-19 12:39:58 PDT
Hmm. Ok. Thanks for taking a look. I thought it was safer to refer to members directly even if those methods are marked as inline. My understanding was that "inline" is only a hint that the compiler is free to ignore. Somehow it does not feel right to call methods to access local members.
Note You need to log in before you can comment on or make changes to this bug.