Bug 99851

Summary: Obsolete code in User Timing implementation
Product: WebKit Reporter: pdeng6 <pan.deng>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

pdeng6
Reported 2012-10-19 10:12:30 PDT
PlatformString.h, prefix of webkitNow is removed. 'first' and 'second' are replaced by 'key' 'value' for HashMap iterator
Attachments
Patch (2.90 KB, patch)
2012-10-19 10:16 PDT, pdeng6 		no flags
DetailsFormatted DiffDiff
Patch (2.87 KB, patch)
2012-10-19 18:00 PDT, pdeng6 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
pdeng6
Comment 1 2012-10-19 10:16:34 PDT
Created attachment 169643 [details] Patch
WebKit Review Bot
Comment 2 2012-10-19 10:57:38 PDT
Comment on attachment 169643 [details] Patch Rejecting attachment 169643 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 12732 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 12732. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14465531
pdeng6
Comment 3 2012-10-19 18:00:38 PDT
Created attachment 169734 [details] Patch
WebKit Review Bot
Comment 4 2012-10-22 15:34:47 PDT
Comment on attachment 169734 [details] Patch Clearing flags on attachment: 169734 Committed r132146: <http://trac.webkit.org/changeset/132146>
WebKit Review Bot
Comment 5 2012-10-22 15:34:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.