Bug 99824

Summary:

REGRESSION (r131836): failures in list styles tests on EFL, GTK

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

Tools / Tests

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, ggaren, msaboff, naginenis, webkit.review.bot

Priority:

Keywords:

Gtk, LayoutTestFailure, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Speculative fix to test failures	none
Updated Speculative Fix	none

Zan Dobersek

Reported 2012-10-19 02:52:44 PDT

The following 3 tests started failing on GTK and EFL after r131836 landed: fast/lists/w3-css3-list-styles-alphabetic.html fast/lists/w3-css3-list-styles-fallback-style.html fast/lists/w3-list-styles.html http://trac.webkit.org/changeset/131836 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Flists%2Fw3 The tests pass without a problem in WebKit2 on both GTK and EFL. I'd say there's something in the WebKit layer that both ports fail to do.

Attachments
Speculative fix to test failures (1.58 KB, patch) 2012-10-19 09:28 PDT, Michael Saboff	no flags	Details Formatted Diff Diff
Updated Speculative Fix (3.81 KB, patch) 2012-10-23 14:31 PDT, Michael Saboff	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Michael Saboff

Comment 1 2012-10-19 09:28:07 PDT

Created attachment 169635 [details] Speculative fix to test failures Could one of the GTK and/or EFL platform people check to see if this patch addresses the test failures?

Zan Dobersek

Comment 2 2012-10-19 11:44:23 PDT

(In reply to comment #1) > Created an attachment (id=169635) [details] > Speculative fix to test failures > > Could one of the GTK and/or EFL platform people check to see if this patch addresses the test failures? No, the failures are still there. GTK (and I think EFL as well) uses the ICU Unicode backend by default.

Michael Saboff

Comment 3 2012-10-23 14:31:19 PDT

Created attachment 170235 [details] Updated Speculative Fix Zan, can you try out this patch?

Zan Dobersek

Comment 4 2012-10-24 00:09:39 PDT

(In reply to comment #3) > Created an attachment (id=170235) [details] > Updated Speculative Fix > > Zan, can you try out this patch? This patch works, the tests pass.

Zan Dobersek

Comment 5 2012-10-24 04:16:45 PDT

(In reply to comment #4) > (In reply to comment #3) > > Created an attachment (id=170235) [details] [details] > > Updated Speculative Fix > > > > Zan, can you try out this patch? > > This patch works, the tests pass. Testing it a bit further, no other regressions occurred, so I think the patch is good for review.

WebKit Review Bot

Comment 6 2012-10-25 11:41:07 PDT

Comment on attachment 170235 [details] Updated Speculative Fix Clearing flags on attachment: 170235 Committed r132507: <http://trac.webkit.org/changeset/132507>

WebKit Review Bot

Comment 7 2012-10-25 11:41:11 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.