Bug 99789

Summary: Deque can use std::reverse_iterator for its reverse iterators
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, darin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Anders Carlsson
Reported 2012-10-18 18:20:37 PDT
Deque can use std::reverse_iterator for its reverse iterators
Attachments
Patch (10.15 KB, patch)
2012-10-18 18:22 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-10-18 18:22:24 PDT
Created attachment 169526 [details] Patch
WebKit Review Bot
Comment 2 2012-10-18 18:25:29 PDT
Attachment 169526 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/De..." exit_code: 1 Source/WTF/wtf/Deque.h:52: reverse_iterator is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/Deque.h:53: const_reverse_iterator is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/Deque.h:160: difference_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/Deque.h:164: iterator_category is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/Deque.h:191: difference_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/Deque.h:195: iterator_category is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3 2012-10-19 10:43:15 PDT
Comment on attachment 169526 [details] Patch Clearing flags on attachment: 169526 Committed r131920: <http://trac.webkit.org/changeset/131920>
WebKit Review Bot
Comment 4 2012-10-19 10:43:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.